components/download/internal/background_download_service_impl_unittest.cc - Issue 2851303003: Add the download component and initial setup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/download/internal/background_download_service_impl_unittest.cc

Issue 2851303003: Add the download component and initial setup (Closed)

Patch Set: Removed accidental rename Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/download/internal/background_download_service_impl.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 TEST(DownloadServiceImplTest, DummyTest) {

	10 EXPECT_TRUE(true);

	11 }
	Peter Beverloo 2017/05/02 16:12:20 I'd just remove this file. The name of the test do I'd just remove this file. The name of the test doesn't match the class it'd hypothetically be testing, and it doesn't do anything anyway. Peter Beverloo 2017/05/02 16:16:47 Oh to add the target. Sure. Rename the test anyway Show quoted text On 2017/05/02 16:12:20, Peter Beverloo wrote: > I'd just remove this file. The name of the test doesn't match the class it'd > hypothetically be testing, and it doesn't do anything anyway. Oh to add the target. Sure. Rename the test anyway? :) David Trainor- moved to gerrit 2017/05/03 06:02:58 Done. Show quoted text On 2017/05/02 16:16:47, Peter Beverloo wrote: > On 2017/05/02 16:12:20, Peter Beverloo wrote: > > I'd just remove this file. The name of the test doesn't match the class it'd > > hypothetically be testing, and it doesn't do anything anyway. > > Oh to add the target. Sure. Rename the test anyway? :) Done.
OLD	NEW