Move evdev events support into EventFactoryDelegateEvdev

Move evdev events support into EventFactoryDelegateEvdev

And introduce a gyp variable use_ozone_evdev to allow this feature to be
removed from the build. Additionally, the --ozone-events flag is introduced
to select an EventFactoryDelegateOzone implementation to use.

If an embedder or out-of-tree EventFactoryDelegateOzone implementation
calls SetEventFactoryDelegateOzone during initialization, the flag has no
effect.

BUG=none
TEST=Build & run content_shell, ui_unittests with use_ozone=1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229950

[rjkroege, 2013-10-18 18:57:55]

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode121
ui/events/events.gyp:121: 'defines': ['USE_OZONE_EVDEV=1'],
it is conventional to make the define in common.gypi

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode123
ui/events/events.gyp:123: 'sources/': [
this is atypical. the typical pattern is more like:

['use_ozone_evdev==0', {
  blah
]

given the rule, I think it's reasonable to toss the _evdev suffix.

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
File ui/events/ozone/event_factory_delegate_ozone.h (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
ui/events/ozone/event_factory_delegate_ozone.h:21: virtual
~EventFactoryDelegateOzone() {}
clang on at least some platforms requires virtual bodies to not be inline.
ozone-for-windows (as terrifying as that sounds) would also require that the
code is the .cc file.

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
File ui/events/ozone/event_factory_ozone.h (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
ui/events/ozone/event_factory_ozone.h:37: static std::string
GetRequestedDelegate();
you're going to change this right?

[spang, 2013-10-21 18:46:01]

On 2013/10/18 18:57:55, rjkroege wrote:
> https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp
> File ui/events/events.gyp (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode121
> ui/events/events.gyp:121: 'defines': ['USE_OZONE_EVDEV=1'],
> it is conventional to make the define in common.gypi
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode123
> ui/events/events.gyp:123: 'sources/': [
> this is atypical. the typical pattern is more like:
> 
> ['use_ozone_evdev==0', {
>   blah
> ]
> 
> given the rule, I think it's reasonable to toss the _evdev suffix.
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> File ui/events/ozone/event_factory_delegate_ozone.h (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> ui/events/ozone/event_factory_delegate_ozone.h:21: virtual
> ~EventFactoryDelegateOzone() {}
> clang on at least some platforms requires virtual bodies to not be inline.
> ozone-for-windows (as terrifying as that sounds) would also require that the
> code is the .cc file.
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> File ui/events/ozone/event_factory_ozone.h (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> ui/events/ozone/event_factory_ozone.h:37: static std::string
> GetRequestedDelegate();
> you're going to change this right?

I need to think about how out-of-tree delegates should work. For now, let's keep
SetEventFactoryDelegateOzone() and not worry about interaction with the
command-line-flag. Would like to land reorg this before opening up that can of
worms.

[spang, 2013-10-21 18:46:11]

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode121
ui/events/events.gyp:121: 'defines': ['USE_OZONE_EVDEV=1'],
On 2013/10/18 18:57:55, rjkroege wrote:
> it is conventional to make the define in common.gypi

This is the difference between a rebuilding in a few seconds vs rebuilding the
entire application when the flag is changed. Reducing the scope of ifdefs seem
worthwhile to me.

https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode123
ui/events/events.gyp:123: 'sources/': [
On 2013/10/18 18:57:55, rjkroege wrote:
> this is atypical. the typical pattern is more like:
> 
> ['use_ozone_evdev==0', {
>   blah
> ]
> 
> given the rule, I think it's reasonable to toss the _evdev suffix.
> 

Ok, will rename all these files.

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
File ui/events/ozone/event_factory_delegate_ozone.h (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
ui/events/ozone/event_factory_delegate_ozone.h:21: virtual
~EventFactoryDelegateOzone() {}
On 2013/10/18 18:57:55, rjkroege wrote:
> clang on at least some platforms requires virtual bodies to not be inline.
> ozone-for-windows (as terrifying as that sounds) would also require that the
> code is the .cc file.

Will create event_factory_delegate_ozone.cc

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
File ui/events/ozone/event_factory_ozone.h (right):

https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
ui/events/ozone/event_factory_ozone.h:37: static std::string
GetRequestedDelegate();
On 2013/10/18 18:57:55, rjkroege wrote:
> you're going to change this right?

Moved to anonymous scope for now.

[rjkroege, 2013-10-21 19:37:16]

On 2013/10/21 18:46:11, spang wrote:
> https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp
> File ui/events/events.gyp (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode121
> ui/events/events.gyp:121: 'defines': ['USE_OZONE_EVDEV=1'],
> On 2013/10/18 18:57:55, rjkroege wrote:
> > it is conventional to make the define in common.gypi
> 
> This is the difference between a rebuilding in a few seconds vs rebuilding the
> entire application when the flag is changed. Reducing the scope of ifdefs seem
> worthwhile to me.

You convinced me. I'll be interested to see what comes of this.

> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/events.gyp#newcode123
> ui/events/events.gyp:123: 'sources/': [
> On 2013/10/18 18:57:55, rjkroege wrote:
> > this is atypical. the typical pattern is more like:
> > 
> > ['use_ozone_evdev==0', {
> >   blah
> > ]
> > 
> > given the rule, I think it's reasonable to toss the _evdev suffix.
> > 
> 
> Ok, will rename all these files.
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> File ui/events/ozone/event_factory_delegate_ozone.h (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> ui/events/ozone/event_factory_delegate_ozone.h:21: virtual
> ~EventFactoryDelegateOzone() {}
> On 2013/10/18 18:57:55, rjkroege wrote:
> > clang on at least some platforms requires virtual bodies to not be inline.
> > ozone-for-windows (as terrifying as that sounds) would also require that the
> > code is the .cc file.
> 
> Will create event_factory_delegate_ozone.cc
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> File ui/events/ozone/event_factory_ozone.h (right):
> 
>
https://codereview.chromium.org/28513004/diff/1/ui/events/ozone/event_factory...
> ui/events/ozone/event_factory_ozone.h:37: static std::string
> GetRequestedDelegate();
> On 2013/10/18 18:57:55, rjkroege wrote:
> > you're going to change this right?
> 
> Moved to anonymous scope for now.

[rjkroege, 2013-10-21 19:43:54]

lgtm

[sadrul, 2013-10-21 20:22:54]

non-ozone code lgtm with the suggested changes.

https://codereview.chromium.org/28513004/diff/80001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/28513004/diff/80001/ui/events/events.gyp#newc...
ui/events/events.gyp:126: ['exclude', '^ozone/evdev/*'],
Move this rule into build/filename_rules.gypi (for '*/evdev/*')

https://codereview.chromium.org/28513004/diff/80001/ui/ui_unittests.gypi
File ui/ui_unittests.gypi (right):

https://codereview.chromium.org/28513004/diff/80001/ui/ui_unittests.gypi#newc...
ui/ui_unittests.gypi:342: }],
You shouldn't need this once you add the rule in filename_rules

[spang, 2013-10-21 20:32:03]

https://codereview.chromium.org/28513004/diff/80001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/28513004/diff/80001/ui/events/events.gyp#newc...
ui/events/events.gyp:126: ['exclude', '^ozone/evdev/*'],
On 2013/10/21 20:22:54, sadrul wrote:
> Move this rule into build/filename_rules.gypi (for '*/evdev/*')

Done.

https://codereview.chromium.org/28513004/diff/80001/ui/ui_unittests.gypi
File ui/ui_unittests.gypi (right):

https://codereview.chromium.org/28513004/diff/80001/ui/ui_unittests.gypi#newc...
ui/ui_unittests.gypi:342: }],
On 2013/10/21 20:22:54, sadrul wrote:
> You shouldn't need this once you add the rule in filename_rules

Done.

[commit-bot: I haz the power, 2013-10-21 20:38:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/28513004/180001

[commit-bot: I haz the power, 2013-10-21 23:09:51]

Change committed as 229950