services/shape_detection/barcode_detection_impl_mac.mm - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shape_detection/barcode_detection_impl_mac.mm

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/shape_detection/barcode_detection_impl_mac.mm

diff --git a/services/shape_detection/barcode_detection_impl_mac.mm b/services/shape_detection/barcode_detection_impl_mac.mm

index ec0ac0bb6219482cdf7e8124cc9dfa566a7470cd..777945f2dcf2f48cd1f7b39006cba50b92d03b08 100644

--- a/services/shape_detection/barcode_detection_impl_mac.mm

+++ b/services/shape_detection/barcode_detection_impl_mac.mm

@@ -33,6 +33,7 @@ void RunCallbackWithNoBarcodes(

// static

void BarcodeDetectionImpl::Create(

+ const service_manager::BindSourceInfo& source_info,

shape_detection::mojom::BarcodeDetectionRequest request) {

// Barcode detection needs at least MAC OS X 10.10.

if (!base::mac::IsAtLeastOS10_10())