Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: services/service_manager/public/cpp/binder_registry.h

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/binder_registry.h
diff --git a/services/service_manager/public/cpp/binder_registry.h b/services/service_manager/public/cpp/binder_registry.h
index 15d08a04667fbc3968ec833a511a0edec0b87df5..133983c7e884b3f23de99f72a79ff62eb98a5aae 100644
--- a/services/service_manager/public/cpp/binder_registry.h
+++ b/services/service_manager/public/cpp/binder_registry.h
@@ -28,28 +28,16 @@ class BinderRegistry {
BinderRegistry();
~BinderRegistry();
- // Provide a callback to be run when a request to bind |Interface| is received
- // by this registry.
template <typename Interface>
void AddInterface(
- const base::Callback<void(mojo::InterfaceRequest<Interface>)>& callback,
+ const base::Callback<void(const BindSourceInfo&,
+ mojo::InterfaceRequest<Interface>)>& callback,
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner =
nullptr) {
SetInterfaceBinder(Interface::Name_,
base::MakeUnique<internal::CallbackBinder<Interface>>(
callback, task_runner));
}
- template <typename Interface>
- void AddInterface(
- const base::Callback<void(const BindSourceInfo&,
- mojo::InterfaceRequest<Interface>)>& callback,
- const scoped_refptr<base::SingleThreadTaskRunner>& task_runner =
- nullptr) {
- SetInterfaceBinder(
- Interface::Name_,
- base::MakeUnique<internal::CallbackBinderWithSourceInfo<Interface>>(
- callback, task_runner));
- }
void AddInterface(
const std::string& interface_name,
const base::Callback<void(mojo::ScopedMessagePipeHandle)>& callback,

Powered by Google App Engine
This is Rietveld 408576698