content/browser/push_messaging/push_messaging_manager.cc - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_manager.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/push_messaging/push_messaging_manager.cc

diff --git a/content/browser/push_messaging/push_messaging_manager.cc b/content/browser/push_messaging/push_messaging_manager.cc

index 1a79fc2bc804c46cbe28c8daf4fbf555dd96699f..33ee69ca54ca4d6e6cec48bc1cea026197129c09 100644

--- a/content/browser/push_messaging/push_messaging_manager.cc

+++ b/content/browser/push_messaging/push_messaging_manager.cc

@@ -268,7 +268,9 @@ PushMessagingManager::PushMessagingManager(

PushMessagingManager::~PushMessagingManager() {}

-void PushMessagingManager::BindRequest(mojom::PushMessagingRequest request) {

+void PushMessagingManager::BindRequest(

+ const service_manager::BindSourceInfo& source_info,

+ mojom::PushMessagingRequest request) {

bindings_.AddBinding(this, std::move(request));

}