components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/browser/distiller_javascript_service_impl.cc ('k') | components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

diff --git a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

index 6ace08d3ab3db913054d12f957367f557558f189..f3ad5557d072f6e18884f45c0bda176fac310bd9 100644

--- a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

+++ b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

@@ -11,6 +11,7 @@

#include "components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h"

#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_frame_observer.h"

+#include "services/service_manager/public/cpp/bind_source_info.h"

#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "v8/include/v8.h"

@@ -40,7 +41,8 @@ class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {

private:

void CreateDistillerPageNotifierService(

- mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request);

+ const service_manager::BindSourceInfo& source_info,

+ mojom::DistillerPageNotifierServiceRequest request);

// RenderFrameObserver implementation.

void OnDestruct() override;