components/contextual_search/renderer/overlay_js_render_frame_observer.cc - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.h ('k') | components/discardable_memory/service/discardable_shared_memory_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

index 52aa6164cfab19d5e68a4fdfd0b90df73aa43e57..0464a82ce05972c672da3a4d411c29daaf7e9248 100644

--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

@@ -37,7 +37,8 @@ void OverlayJsRenderFrameObserver::RegisterMojoInterface() {

}

void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService(

- mojo::InterfaceRequest<mojom::OverlayPageNotifierService> request) {

+ const service_manager::BindSourceInfo& source_info,

+ mojom::OverlayPageNotifierServiceRequest request) {

mojo::MakeStrongBinding(

base::MakeUnique<OverlayPageNotifierServiceImpl>(

weak_factory_.GetWeakPtr()),