components/contextual_search/browser/contextual_search_js_api_service_impl.cc - Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/browser/contextual_search_js_api_service_impl.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/contextual_search/browser/contextual_search_js_api_service_impl.h ('k') | components/contextual_search/renderer/overlay_js_render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/browser/contextual_search_js_api_service_impl.cc

diff --git a/components/contextual_search/browser/contextual_search_js_api_service_impl.cc b/components/contextual_search/browser/contextual_search_js_api_service_impl.cc

index c724c2ecde9a35d6ac79f5cdfd77f0a654417c5c..5ebfd3ffd48f5f8940ea44ed29cdf6319438eb8d 100644

--- a/components/contextual_search/browser/contextual_search_js_api_service_impl.cc

+++ b/components/contextual_search/browser/contextual_search_js_api_service_impl.cc

@@ -27,7 +27,8 @@ void ContextualSearchJsApiServiceImpl::HandleSetCaption(

// static

void CreateContextualSearchJsApiService(

ContextualSearchJsApiHandler* contextual_search_js_api_handler,

- mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request) {

+ const service_manager::BindSourceInfo& source_info,

+ mojom::ContextualSearchJsApiServiceRequest request) {

mojo::MakeStrongBinding(base::MakeUnique<ContextualSearchJsApiServiceImpl>(

contextual_search_js_api_handler),

std::move(request));