Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: content/renderer/image_downloader/image_downloader_impl.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/image_downloader/image_downloader_impl.h" 5 #include "content/renderer/image_downloader/image_downloader_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 DCHECK(render_frame); 92 DCHECK(render_frame);
93 binding_.set_connection_error_handler( 93 binding_.set_connection_error_handler(
94 base::Bind(&ImageDownloaderImpl::OnDestruct, base::Unretained(this))); 94 base::Bind(&ImageDownloaderImpl::OnDestruct, base::Unretained(this)));
95 } 95 }
96 96
97 ImageDownloaderImpl::~ImageDownloaderImpl() {} 97 ImageDownloaderImpl::~ImageDownloaderImpl() {}
98 98
99 // static 99 // static
100 void ImageDownloaderImpl::CreateMojoService( 100 void ImageDownloaderImpl::CreateMojoService(
101 RenderFrame* render_frame, 101 RenderFrame* render_frame,
102 const service_manager::BindSourceInfo& source_info,
102 mojom::ImageDownloaderRequest request) { 103 mojom::ImageDownloaderRequest request) {
103 DVLOG(1) << "ImageDownloaderImpl::CreateMojoService"; 104 DVLOG(1) << "ImageDownloaderImpl::CreateMojoService";
104 DCHECK(render_frame); 105 DCHECK(render_frame);
105 106
106 // Owns itself. Will be deleted when message pipe is destroyed or RenderFrame 107 // Owns itself. Will be deleted when message pipe is destroyed or RenderFrame
107 // is destructed. 108 // is destructed.
108 new ImageDownloaderImpl(render_frame, std::move(request)); 109 new ImageDownloaderImpl(render_frame, std::move(request));
109 } 110 }
110 111
111 // ImageDownloader methods: 112 // ImageDownloader methods:
(...skipping 23 matching lines...) Expand all
135 136
136 std::move(callback).Run(http_status_code, result_images, 137 std::move(callback).Run(http_status_code, result_images,
137 result_original_image_sizes); 138 result_original_image_sizes);
138 } 139 }
139 140
140 void ImageDownloaderImpl::OnDestruct() { 141 void ImageDownloaderImpl::OnDestruct() {
141 delete this; 142 delete this;
142 } 143 }
143 144
144 } // namespace content 145 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/image_downloader/image_downloader_impl.h ('k') | content/renderer/media/media_devices_listener_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698