Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/utility/media_router/dial_device_description_parser_impl.h

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_ 5 #ifndef CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_
6 #define CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_ 6 #define CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/common/media_router/mojo/dial_device_description_parser.mojom.h " 9 #include "chrome/common/media_router/mojo/dial_device_description_parser.mojom.h "
10 #include "services/service_manager/public/cpp/bind_source_info.h"
10 11
11 namespace media_router { 12 namespace media_router {
12 13
13 // Implementation of Mojo DialDeviceDescriptionParser. It accepts device 14 // Implementation of Mojo DialDeviceDescriptionParser. It accepts device
14 // description parsing request from browser process, and handles it in utility 15 // description parsing request from browser process, and handles it in utility
15 // process. Class must be created and destroyed on utility thread. 16 // process. Class must be created and destroyed on utility thread.
16 class DialDeviceDescriptionParserImpl 17 class DialDeviceDescriptionParserImpl
17 : public chrome::mojom::DialDeviceDescriptionParser { 18 : public chrome::mojom::DialDeviceDescriptionParser {
18 public: 19 public:
19 DialDeviceDescriptionParserImpl(); 20 DialDeviceDescriptionParserImpl();
20 ~DialDeviceDescriptionParserImpl() override; 21 ~DialDeviceDescriptionParserImpl() override;
21 22
22 static void Create(chrome::mojom::DialDeviceDescriptionParserRequest request); 23 static void Create(const service_manager::BindSourceInfo& source_info,
24 chrome::mojom::DialDeviceDescriptionParserRequest request);
23 25
24 private: 26 private:
25 friend class DialDeviceDescriptionParserImplTest; 27 friend class DialDeviceDescriptionParserImplTest;
26 28
27 // extensions::mojom::DialDeviceDescriptionParser: 29 // extensions::mojom::DialDeviceDescriptionParser:
28 void ParseDialDeviceDescription( 30 void ParseDialDeviceDescription(
29 const std::string& device_description_xml_data, 31 const std::string& device_description_xml_data,
30 const ParseDialDeviceDescriptionCallback& callback) override; 32 const ParseDialDeviceDescriptionCallback& callback) override;
31 33
32 // Processes the result of getting device description. Returns valid 34 // Processes the result of getting device description. Returns valid
33 // DialDeviceDescriptionPtr if processing succeeds; otherwise returns nullptr. 35 // DialDeviceDescriptionPtr if processing succeeds; otherwise returns nullptr.
34 // |xml|: The device description xml text. 36 // |xml|: The device description xml text.
35 chrome::mojom::DialDeviceDescriptionPtr Parse(const std::string& xml); 37 chrome::mojom::DialDeviceDescriptionPtr Parse(const std::string& xml);
36 38
37 base::ThreadChecker thread_checker_; 39 base::ThreadChecker thread_checker_;
38 40
39 DISALLOW_COPY_AND_ASSIGN(DialDeviceDescriptionParserImpl); 41 DISALLOW_COPY_AND_ASSIGN(DialDeviceDescriptionParserImpl);
40 }; 42 };
41 43
42 } // namespace media_router 44 } // namespace media_router
43 45
44 #endif // CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_ 46 #endif // CHROME_UTILITY_MEDIA_ROUTER_DIAL_DEVICE_DESCRIPTION_PARSER_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/utility/extensions/extensions_handler.cc ('k') | chrome/utility/media_router/dial_device_description_parser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698