Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2851173004: Eliminate bind callback that doesn't take a BindSourceInfo parameter. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/browser/renderer_host/aw_render_view_host_ext.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/aw_content_browser_client.h" 5 #include "android_webview/browser/aw_content_browser_client.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/aw_browser_context.h" 9 #include "android_webview/browser/aw_browser_context.h"
10 #include "android_webview/browser/aw_browser_main_parts.h" 10 #include "android_webview/browser/aw_browser_main_parts.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 #include "ui/resources/grit/ui_resources.h" 67 #include "ui/resources/grit/ui_resources.h"
68 68
69 #if BUILDFLAG(ENABLE_SPELLCHECK) 69 #if BUILDFLAG(ENABLE_SPELLCHECK)
70 #include "components/spellcheck/browser/spellcheck_message_filter_platform.h" 70 #include "components/spellcheck/browser/spellcheck_message_filter_platform.h"
71 #include "components/spellcheck/common/spellcheck_switches.h" 71 #include "components/spellcheck/common/spellcheck_switches.h"
72 #endif 72 #endif
73 73
74 using content::BrowserThread; 74 using content::BrowserThread;
75 using content::ResourceType; 75 using content::ResourceType;
76 76
77 namespace service_manager {
78 struct BindSourceInfo;
79 }
80
77 namespace android_webview { 81 namespace android_webview {
78 namespace { 82 namespace {
79 83
80 // TODO(sgurun) move this to its own file. 84 // TODO(sgurun) move this to its own file.
81 // This class filters out incoming aw_contents related IPC messages for the 85 // This class filters out incoming aw_contents related IPC messages for the
82 // renderer process on the IPC thread. 86 // renderer process on the IPC thread.
83 class AwContentsMessageFilter : public content::BrowserMessageFilter { 87 class AwContentsMessageFilter : public content::BrowserMessageFilter {
84 public: 88 public:
85 explicit AwContentsMessageFilter(int process_id); 89 explicit AwContentsMessageFilter(int process_id);
86 90
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 void AwContentsMessageFilter::OnSubFrameCreated(int parent_render_frame_id, 161 void AwContentsMessageFilter::OnSubFrameCreated(int parent_render_frame_id,
158 int child_render_frame_id) { 162 int child_render_frame_id) {
159 AwContentsIoThreadClient::SubFrameCreated( 163 AwContentsIoThreadClient::SubFrameCreated(
160 process_id_, parent_render_frame_id, child_render_frame_id); 164 process_id_, parent_render_frame_id, child_render_frame_id);
161 } 165 }
162 166
163 AwLocaleManager* g_locale_manager = NULL; 167 AwLocaleManager* g_locale_manager = NULL;
164 168
165 // A dummy binder for mojo interface autofill::mojom::PasswordManagerDriver. 169 // A dummy binder for mojo interface autofill::mojom::PasswordManagerDriver.
166 void DummyBindPasswordManagerDriver( 170 void DummyBindPasswordManagerDriver(
171 const service_manager::BindSourceInfo& source_info,
167 autofill::mojom::PasswordManagerDriverRequest request) {} 172 autofill::mojom::PasswordManagerDriverRequest request) {}
168 173
169 } // anonymous namespace 174 } // anonymous namespace
170 175
171 // TODO(yirui): can use similar logic as in PrependToAcceptLanguagesIfNecessary 176 // TODO(yirui): can use similar logic as in PrependToAcceptLanguagesIfNecessary
172 // in chrome/browser/android/preferences/pref_service_bridge.cc 177 // in chrome/browser/android/preferences/pref_service_bridge.cc
173 // static 178 // static
174 std::string AwContentBrowserClient::GetAcceptLangsImpl() { 179 std::string AwContentBrowserClient::GetAcceptLangsImpl() {
175 // Start with the current locale(s) in BCP47 format. 180 // Start with the current locale(s) in BCP47 format.
176 std::string locales_string = g_locale_manager->GetLocaleList(); 181 std::string locales_string = g_locale_manager->GetLocaleList();
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 render_frame_host)); 565 render_frame_host));
561 566
562 // Although WebView does not support password manager feature, renderer code 567 // Although WebView does not support password manager feature, renderer code
563 // could still request this interface, so we register a dummy binder which 568 // could still request this interface, so we register a dummy binder which
564 // just drops the incoming request, to avoid the 'Failed to locate a binder 569 // just drops the incoming request, to avoid the 'Failed to locate a binder
565 // for interface' error log.. 570 // for interface' error log..
566 registry->AddInterface(base::Bind(&DummyBindPasswordManagerDriver)); 571 registry->AddInterface(base::Bind(&DummyBindPasswordManagerDriver));
567 } 572 }
568 573
569 } // namespace android_webview 574 } // namespace android_webview
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/renderer_host/aw_render_view_host_ext.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698