Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2851163003: Revert trigonometric function updates. (Closed)

Created:
3 years, 7 months ago by floitsch
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert trigonometric function updates. The VM has a fingerprint on the function and failed during compilation. Revert "Fix patch errors." This reverts commit ff1d7488d97ca63dca5767f597a3eb24e8b551d4. Revert "Update documentation on trignometric functions." This reverts commit 40220ec0766bb2b179d3623d3f298223df842279. BUG= Committed: https://github.com/dart-lang/sdk/commit/05e0e1ea40627c00812fd129bd81880e564cb9ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/lib/math_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/math_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/math/math.dart View 7 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
floitsch
TBR.
3 years, 7 months ago (2017-05-01 14:05:37 UTC) #2
floitsch
3 years, 7 months ago (2017-05-01 14:07:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
05e0e1ea40627c00812fd129bd81880e564cb9ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698