Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 285103002: Add GN build for parts of gpu and ozone. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
rjkroege, piman, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, piman+watch_chromium.org, rjkroege, kalyank, tfarina
Visibility:
Public.

Description

Add GN build for parts of gpu and ozone. Moves existing ozone platform flag to new .gni file with all ozone flags in it. R=piman@chromium.org, rjkroege@chromium.org, spang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270780

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -11 lines) Patch
M BUILD.gn View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/ui.gni View 1 chunk +0 lines, -2 lines 0 comments Download
A gpu/BUILD.gn View 1 chunk +145 lines, -0 lines 0 comments Download
A gpu/command_buffer/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/khronos/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/builder.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
A ui/gfx/ozone/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/gfx/x/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A ui/gl/BUILD.gn View 1 2 1 chunk +289 lines, -0 lines 0 comments Download
A ui/ozone/BUILD.gn View 1 2 3 1 chunk +60 lines, -0 lines 1 comment Download
A ui/ozone/ozone.gni View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
brettw
Robert: ui/* Antoine: gpu/* ( I know you aren't owners of everything here, but I ...
6 years, 7 months ago (2014-05-14 18:30:37 UTC) #1
spang
FYI - rjkroege is on vacation https://codereview.chromium.org/285103002/diff/40001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (left): https://codereview.chromium.org/285103002/diff/40001/ui/gfx/BUILD.gn#oldcode338 ui/gfx/BUILD.gn:338: configs += [ ...
6 years, 7 months ago (2014-05-14 19:03:05 UTC) #2
piman
lgtm
6 years, 7 months ago (2014-05-14 19:29:20 UTC) #3
spang
lgtm https://codereview.chromium.org/285103002/diff/40001/ui/ozone/ozone.gni File ui/ozone/ozone.gni (right): https://codereview.chromium.org/285103002/diff/40001/ui/ozone/ozone.gni#newcode11 ui/ozone/ozone.gni:11: ozone_platform = "test" It gets passed to generate_ozone_platform_list.py ...
6 years, 7 months ago (2014-05-14 19:56:17 UTC) #4
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 7 months ago (2014-05-15 04:45:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/285103002/60001
6 years, 7 months ago (2014-05-15 04:47:25 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 07:57:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 08:00:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67830)
6 years, 7 months ago (2014-05-15 08:00:46 UTC) #9
rjkroege
Does the config on the ozone builder build and our CrOS build both build with ...
6 years, 7 months ago (2014-05-15 16:08:54 UTC) #10
brettw
There is currently no bot that compiles ozone in GN. Enabling this is a work ...
6 years, 7 months ago (2014-05-15 18:32:16 UTC) #11
brettw
6 years, 7 months ago (2014-05-15 19:39:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 manually as r270780.

Powered by Google App Engine
This is Rietveld 408576698