Issue 2851023: dhcpcd-dbus.c::msg_handler(): Call raise() instead of handle_signal(),

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2851023: dhcpcd-dbus.c::msg_handler(): Call raise() instead of handle_signal(), (Closed)

Created:
10 years, 6 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/dhcpcd.git

Visibility:
Public.

Description

dhcpcd-dbus.c::msg_handler(): Call raise() instead of handle_signal(), since the latter is looking for something on the internal signal pipe, and not paying attention to its argument. TEST=Send org.chromium.dhcpcd.Release method to dhcpcd, note that it exits (possibly by sending the method call twice and noting that it fails to contact dhcpcd the second time). Details: Start a dhcpcd with a known DBus ID by running "dbus-monitor --system interface=org.chromium.dhcpcd" and plugging in an Ethernet cable; look for the "sender=" value. Send the release command with "dbus-send --system --print-reply --dest=[DBus ID] /org/chromium/dhcpcd org.chromium.dhcpcd.Release"

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	dhcpcd-dbus.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages