Issue 2851022: dbus-dict.c::append_config_array(): Fix up DBUS_TYPE_UINT32 handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2851022: dbus-dict.c::append_config_array(): Fix up DBUS_TYPE_UINT32 handling (Closed)

Created:
10 years, 6 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/dhcpcd.git

Visibility:
Public.

Description

dbus-dict.c::append_config_array(): Fix up DBUS_TYPE_UINT32 handling to work for arrays of more than one element by parsing the current token rather than the entire string and avoiding fallthrough to the default case. TEST=Run flimflam (with -P dhclient) and connect to a network where the DHCP server provides multiple DNS servers. Check that the resulting resolv.conf file contains all of the DNS servers.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	dbus-dict.c	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

Think this comes straight from dhcpcd-dbus upstream; might want to check and forward to Ray.

10 years, 6 months ago (2010-06-24 19:26:06 UTC) #2

LGTM

Expand Messages | Collapse Messages