Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2850943002: If MHTML saving is cancelled, delete the page afterwards. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
index fd489a7f4565ca1f36b3dcc407c7e76976d412de..ef8600c1f5932539ac8227bcbcccc6a3cd1db812 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
@@ -43,7 +43,7 @@ const bool kUserRequested = true;
// Mock OfflinePageModel for testing the SavePage calls
class MockOfflinePageModel : public StubOfflinePageModel {
public:
- MockOfflinePageModel() : mock_saving_(false) {}
+ MockOfflinePageModel() : mock_saving_(false), mock_deleting_(false) {}
~MockOfflinePageModel() override {}
void SavePage(const SavePageParams& save_page_params,
@@ -77,10 +77,17 @@ class MockOfflinePageModel : public StubOfflinePageModel {
SavePageResult::ALREADY_EXISTS, 123456));
}
+ void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
+ const DeletePageCallback& callback) override {
+ mock_deleting_ = true;
+ }
+
bool mock_saving() const { return mock_saving_; }
+ bool mock_deleting() const { return mock_deleting_; }
private:
bool mock_saving_;
+ bool mock_deleting_;
SavePageCallback save_page_callback_;
DISALLOW_COPY_AND_ASSIGN(MockOfflinePageModel);
@@ -155,6 +162,7 @@ class BackgroundLoaderOfflinerTest : public testing::Test {
Offliner::RequestStatus request_status() { return request_status_; }
bool cancel_callback_called() { return cancel_callback_called_; }
bool SaveInProgress() const { return model_->mock_saving(); }
+ bool DeleteCalled() const { return model_->mock_deleting(); }
MockOfflinePageModel* model() const { return model_; }
const base::HistogramTester& histograms() const { return histogram_tester_; }
int64_t progress() { return progress_; }
@@ -330,6 +338,7 @@ TEST_F(BackgroundLoaderOfflinerTest, CancelWhenLoaded) {
model()->CompleteSavingAsArchiveCreationFailed();
PumpLoop();
EXPECT_TRUE(cancel_callback_called());
+ EXPECT_TRUE(DeleteCalled());
EXPECT_FALSE(completion_callback_called());
EXPECT_FALSE(SaveInProgress());
EXPECT_FALSE(offliner()->is_loading()); // Offliner reset.

Powered by Google App Engine
This is Rietveld 408576698