pkg/compiler/lib/src/ssa/builder_kernel.dart - Issue 2850933002: kernel backend impact - noSuchMethod helpers are passed a Map literal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2850933002: kernel backend impact - noSuchMethod helpers are passed a Map literal (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder_kernel.dart

diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart

index 7ca8e5b5033beaee8bb5a5449cb3b3ab467af85d..c2c992bc7c1bfece35cf0e74eb0d279491c414cd 100644

--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart

+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart

@@ -1924,7 +1924,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {

inputs.add(argList);

}

- assert(constructor.kind == ir.ProcedureKind.Factory);

+ assert(constructor != null && constructor.kind == ir.ProcedureKind.Factory);

ResolutionInterfaceType type = localsHandler

.substInContext(astAdapter.getDartTypeOfMapLiteral(mapLiteral));