Clean up Linux zygote creation code

content/public/common/sandboxed_process_launcher_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "content/public/common/sandboxed_process_launcher_delegate.h"
+
 #include "build/build_config.h"
-#include "content/public/common/sandboxed_process_launcher_delegate.h"
 
 namespace content {
 
 #if defined(OS_WIN)
 bool SandboxedProcessLauncherDelegate::ShouldLaunchElevated() {
   return false;
 }
 
 bool SandboxedProcessLauncherDelegate::ShouldSandbox() {
   return true;
 }
 
 bool SandboxedProcessLauncherDelegate::DisableDefaultPolicy() {
   return false;
 }
 
 bool SandboxedProcessLauncherDelegate::PreSpawnTarget(
     sandbox::TargetPolicy* policy) {
   return true;
 }
 
 #elif(OS_POSIX)
+
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
-ZygoteHandle* SandboxedProcessLauncherDelegate::GetZygote() {
+ZygoteHandle SandboxedProcessLauncherDelegate::GetZygote() {
   return nullptr;

[James Cook, 2017/04/28 20:07:52]

I could also make this return GetGenericZygote().

[mdempsky, 2017/04/28 22:13:45]

I believe some of the launcher delegate subclasses do not want to use zygotes,
so you'd have to override GetZygote in those to return nullptr instead. I'd
suggest leaving as is.

 }
 #endif  // !defined(OS_MACOSX) && !defined(OS_ANDROID)
 
 base::EnvironmentMap SandboxedProcessLauncherDelegate::GetEnvironment() {
   return base::EnvironmentMap();
 }
 #endif
 
 SandboxType SandboxedProcessLauncherDelegate::GetSandboxType() {
   return SANDBOX_TYPE_INVALID;
 }
 
 }  // namespace content