Clean up Linux zygote creation code

content/browser/zygote_host/zygote_handle_linux.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/zygote_handle_linux.h"
 
 #include "content/browser/zygote_host/zygote_communication_linux.h"
 
 namespace content {
+namespace {
 
-ZygoteHandle CreateZygote() {
-  ZygoteHandle zygote = new ZygoteCommunication();
-  zygote->Init();
-  return zygote;
+// Intentionally leaked.

[James Cook, 2017/04/28 20:07:52]

The old code leaks the ZygoteCommunication object. Is that intentional?

[mdempsky, 2017/04/28 22:13:45]

By "leaks" do you mean that it's not destroyed when the browser process exits?
If so, I think it's just for simplicity. We need to make sure the
ZygoteCommunication object outlives any delegates that might want to use it.

I don't think it "leaks" in the sense that we created it and lose any reference
to it: it's still accessible via GetGenericZygote.

+ZygoteHandle g_generic_zygote = nullptr;
+
+}  // namespace
+
+ZygoteHandle CreateGenericZygote() {
+  CHECK(!g_generic_zygote);
+  g_generic_zygote = new ZygoteCommunication();
+  g_generic_zygote->Init();
+  return g_generic_zygote;
 }
 
-ZygoteHandle* GetGenericZygote() {
-  static ZygoteHandle zygote;
-  return &zygote;
+ZygoteHandle GetGenericZygote() {
+  CHECK(g_generic_zygote);
+  return g_generic_zygote;
 }
 
 }  // namespace content