third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc - Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject. (Closed)

Patch Set: add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html is still broken Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

index e75e3ca158fcbd8fb7668cea5aef5c1ba2d7dc99..2e7ead087095c8acb6dffe1a2ba357fca206ead6 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

@@ -198,8 +198,10 @@ RefPtr<NGLayoutResult> NGFragmentBuilder::ToBoxFragment() {

for (auto& positioned_float : positioned_floats_) {

NGPhysicalFragment* floating_fragment = positioned_float.fragment.Get();

- floating_fragment->SetOffset(positioned_float.offset.ConvertToPhysical(

- writing_mode_, direction_, physical_size, floating_fragment->Size()));

+ floating_fragment->SetOffset(

+ positioned_float.logical_offset.ConvertToPhysical(

+ writing_mode_, direction_, physical_size,

+ floating_fragment->Size()));

}

RefPtr<NGPhysicalBoxFragment> fragment = AdoptRef(new NGPhysicalBoxFragment(