third_party/WebKit/Source/core/layout/ng/ng_block_node.cc - Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject. (Closed)

Patch Set: add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html is still broken Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

index 0dc927d52a2bb31b9b7662ae68e9eca5f35b0d5c..c8328c96d8e102fbef8562e32465e9ac85004f00 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

@@ -78,8 +78,8 @@ void FloatingObjectPositionedUpdated(const NGPositionedFloat& positioned_float,

FloatingObject* floating_object =

ToLayoutBlockFlow(parent)->InsertFloatingObject(*layout_box);

floating_object->SetIsInPlacedTree(false);

- floating_object->SetX(positioned_float.left_offset);

- floating_object->SetY(box_fragment->TopOffset());

+ floating_object->SetX(positioned_float.paint_offset.left);

+ floating_object->SetY(positioned_float.paint_offset.top);

floating_object->SetIsPlaced(true);

floating_object->SetIsInPlacedTree(true);

}