third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc - Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_floating_object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

index 8e58a021c248e8e7abf81d8d62e75be3262f11e1..f73d67f65f7c79a6b1ca6ab192de446bf14641f9 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

@@ -374,6 +374,7 @@ void NGInlineLayoutAlgorithm::LayoutAndPositionFloat(

float_style, float_space->WritingMode(), current_opportunity_.size,

origin_offset, from_offset, margins,

layout_result->PhysicalFragment().Get());

+ floating_object->container_block_offset = ContainerBfcOffset().block_offset;

bool float_does_not_fit = end_position + float_fragment.InlineSize() >

current_opportunity_.InlineSize();