Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2850893003: Add container_block_offset,top_offset to NGFloatingObject. (Closed)
Patch Set: update TestExpectations Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGBlockLayoutAlgorithm_h 5 #ifndef NGBlockLayoutAlgorithm_h
6 #define NGBlockLayoutAlgorithm_h 6 #define NGBlockLayoutAlgorithm_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/geometry/ng_margin_strut.h" 9 #include "core/layout/ng/geometry/ng_margin_strut.h"
10 #include "core/layout/ng/ng_block_break_token.h" 10 #include "core/layout/ng/ng_block_break_token.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // Positions the fragment that knows its BFC offset. 88 // Positions the fragment that knows its BFC offset.
89 NGLogicalOffset PositionWithBfcOffset(const NGBoxFragment&); 89 NGLogicalOffset PositionWithBfcOffset(const NGBoxFragment&);
90 90
91 // Positions using the parent BFC offset. 91 // Positions using the parent BFC offset.
92 // Fragment doesn't know its offset but we can still calculate its BFC 92 // Fragment doesn't know its offset but we can still calculate its BFC
93 // position because the parent fragment's BFC is known. 93 // position because the parent fragment's BFC is known.
94 // Example: 94 // Example:
95 // BFC Offset is known here because of the padding. 95 // BFC Offset is known here because of the padding.
96 // <div style="padding: 1px"> 96 // <div style="padding: 1px">
97 // <div id="empty-div" style="margins: 1px"></div> 97 // <div id="empty-div" style="margins: 1px"></div>
98 NGLogicalOffset PositionWithParentBfc(const NGBoxFragment&); 98 NGLogicalOffset PositionWithParentBfc(const NGConstraintSpace&,
99 const NGBoxFragment&);
100 NGLogicalOffset PositionWithParentBfc(const NGConstraintSpace&);
ikilpatrick 2017/05/09 22:45:23 remove?
Gleb Lanbin 2017/05/09 23:12:07 Done.
99 101
100 NGLogicalOffset PositionLegacy(const NGConstraintSpace& child_space); 102 NGLogicalOffset PositionLegacy(const NGConstraintSpace& child_space);
101 103
102 void FinishFloatChildLayout(const ComputedStyle&, 104 void FinishFloatChildLayout(const ComputedStyle&,
103 const NGConstraintSpace&, 105 const NGConstraintSpace&,
104 const NGLayoutResult*); 106 const NGLayoutResult*);
105 107
106 // Final adjustments before fragment creation. We need to prevent the 108 // Final adjustments before fragment creation. We need to prevent the
107 // fragment from crossing fragmentainer boundaries, and rather create a break 109 // fragment from crossing fragmentainer boundaries, and rather create a break
108 // token if we're out of space. 110 // token if we're out of space.
(...skipping 13 matching lines...) Expand all
122 LayoutUnit max_inline_size_; 124 LayoutUnit max_inline_size_;
123 // MarginStrut for the previous child. 125 // MarginStrut for the previous child.
124 NGMarginStrut curr_margin_strut_; 126 NGMarginStrut curr_margin_strut_;
125 NGLogicalOffset curr_bfc_offset_; 127 NGLogicalOffset curr_bfc_offset_;
126 NGBoxStrut curr_child_margins_; 128 NGBoxStrut curr_child_margins_;
127 }; 129 };
128 130
129 } // namespace blink 131 } // namespace blink
130 132
131 #endif // NGBlockLayoutAlgorithm_h 133 #endif // NGBlockLayoutAlgorithm_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698