Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2850853004: Add 'scanGenericMethodComments' parameter to constructors and scan() functions. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add 'scanGenericMethodComments' parameter to constructors and scan() functions. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f2f1c609046e137d92b590f4bf686a8586b55a26

Patch Set 1 #

Total comments: 2

Patch Set 2 : Parse generic method comments only in strong mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner.dart View 1 chunk +12 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 7 months ago (2017-04-28 21:26:10 UTC) #1
Paul Berry
https://codereview.chromium.org/2850853004/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2850853004/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode384 pkg/analyzer/lib/src/dart/analysis/file_state.dart:384: includeComments: true, scanGenericMethodComments: true); Why not scanGenericMethodComments: analysisOptions.strongMode ?
3 years, 7 months ago (2017-04-28 21:39:52 UTC) #2
scheglov
https://codereview.chromium.org/2850853004/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2850853004/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode384 pkg/analyzer/lib/src/dart/analysis/file_state.dart:384: includeComments: true, scanGenericMethodComments: true); On 2017/04/28 21:39:52, Paul Berry ...
3 years, 7 months ago (2017-04-28 21:42:38 UTC) #3
Paul Berry
lgtm
3 years, 7 months ago (2017-04-28 21:43:36 UTC) #4
scheglov
3 years, 7 months ago (2017-04-28 21:47:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f2f1c609046e137d92b590f4bf686a8586b55a26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698