third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h - Issue 2850813004: Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

Issue 2850813004: Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash. (Closed)

Patch Set: includes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp » ('j') | third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

index 835de009d31fec3b62defc52db30cf714541cb45..1bf70505ecca29bb05af5700205cbaacdc2809d0 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

@@ -6,6 +6,7 @@

#define CredentialsContainer_h

#include "bindings/core/v8/ScriptWrappable.h"

+#include "modules/ModulesExport.h"

#include "platform/heap/Handle.h"

namespace blink {

@@ -15,7 +16,7 @@ class CredentialRequestOptions;

class ScriptPromise;

class ScriptState;

-class CredentialsContainer final

+class MODULES_EXPORT CredentialsContainer final

: public GarbageCollected<CredentialsContainer>,

public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();