Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: components/subresource_filter/core/common/indexed_ruleset.h

Issue 2850813003: Add presubmit script checking FlatBuffer changes. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/common/PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/common/indexed_ruleset.h
diff --git a/components/subresource_filter/core/common/indexed_ruleset.h b/components/subresource_filter/core/common/indexed_ruleset.h
index a9fbd941e02d43c5c48181f9116028f5fb6df3b5..e5206d783fae93e12a56d9ad643647cbc1e228a5 100644
--- a/components/subresource_filter/core/common/indexed_ruleset.h
+++ b/components/subresource_filter/core/common/indexed_ruleset.h
@@ -39,6 +39,12 @@ static_assert(kNGramSize <= sizeof(NGram), "NGram type is too narrow.");
class RulesetIndexer {
public:
// The current binary format version of the indexed ruleset.
+ //
+ // Increase this value when introducing an incompatible change in
+ // IndexedRuleset format, or otherwise willing to nudge clients to rebuild
+ // their ruleset (e.g., a change is compatible, but significantly reduces the
+ // size of the buffer). Note: The PRESUBMIT.py script tries to keep
+ // contributors aware of that.
static const int kIndexedFormatVersion;
RulesetIndexer();
« no previous file with comments | « components/subresource_filter/core/common/PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698