Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2352)

Unified Diff: chrome/browser/extensions/extension_resource_request_policy_apitest.cc

Issue 2850793005: Remove command line/field trial support and configs for Isolate Extensions. (Closed)
Patch Set: Remove more cases of "isolate.*extension" Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_resource_request_policy_apitest.cc
diff --git a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
index 9049e91e7e221a04b0c9f4177e509b50478e7750..488b73979aff3d0fb150a59a9530b0d8eef7cef0 100644
--- a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
+++ b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
@@ -349,11 +349,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
// The iframe should not load |private_page|, which is not web-accessible.
//
- // TODO(alexmos): The failure mode differs on whether or not
- // --isolate-extensions is used: if it is on, the request is canceled and we
- // stay on public.html (see https://crbug.com/656752), and if it's off, the
- // request is blocked in ExtensionNavigationThrottle, which loads an error
- // page into the iframe. This check handles both cases, but we should make
- // the check stricter once --isolate-extensions is on by default.
+ // TODO(alexmos): Make this check stricter, as extensions are now fully
+ // isolated. The failure mode is that the request is canceled and we stay on
+ // public.html (see https://crbug.com/656752).
EXPECT_NE("Private", content);
}

Powered by Google App Engine
This is Rietveld 408576698