Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9599)

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 2850793005: Remove command line/field trial support and configs for Isolate Extensions. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/lazy_background_page_apitest.cc
diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc
index 13d5473025d5d2b13ca13c92ff13989b5a5cba1a..2235cca25bda664e5772500c01a7f30020fca08c 100644
--- a/chrome/browser/extensions/lazy_background_page_apitest.cc
+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc
@@ -633,35 +633,10 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, OnSuspendUseStorageApi) {
// TODO: background page with timer.
// TODO: background page that interacts with popup.
-// Test class to allow test cases to run in --isolate-extensions mode.
-class LazyBackgroundPageIsolatedExtensionsApiTest
- : public LazyBackgroundPageApiTest {
- public:
- LazyBackgroundPageIsolatedExtensionsApiTest() {}
- ~LazyBackgroundPageIsolatedExtensionsApiTest() override {}
-
- void SetUpOnMainThread() override {
- LazyBackgroundPageApiTest::SetUpOnMainThread();
-
- // This is needed to allow example.com to actually resolve and load in
- // tests.
- host_resolver()->AddRule("*", "127.0.0.1");
- }
-
- void SetUpCommandLine(base::CommandLine* command_line) override {
- LazyBackgroundPageApiTest::SetUpCommandLine(command_line);
- command_line->AppendSwitch(switches::kIsolateExtensions);
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(LazyBackgroundPageIsolatedExtensionsApiTest);
-};
-
// Ensure that the events page of an extension is properly torn down and the
-// process does not linger around when running in --isolate-extensions mode.
+// process does not linger around.
// See https://crbug.com/612668.
-IN_PROC_BROWSER_TEST_F(LazyBackgroundPageIsolatedExtensionsApiTest,
- EventProcessCleanup) {
+IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, EventProcessCleanup) {
ASSERT_TRUE(LoadExtensionAndWait("event_page_with_web_iframe"));
// Lazy Background Page doesn't exist anymore.

Powered by Google App Engine
This is Rietveld 408576698