Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/chrome_security_exploit_browsertest.cc

Issue 2850793005: Remove command line/field trial support and configs for Isolate Extensions. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_security_exploit_browsertest.cc
diff --git a/chrome/browser/chrome_security_exploit_browsertest.cc b/chrome/browser/chrome_security_exploit_browsertest.cc
index 89d83fe3c4936c915b7eb1ba2f79d551998b3d6f..789dba1b575e17ae587b8ff135e8d914984c78cf 100644
--- a/chrome/browser/chrome_security_exploit_browsertest.cc
+++ b/chrome/browser/chrome_security_exploit_browsertest.cc
@@ -10,7 +10,6 @@
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/extensions/extension_process_policy.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/notification_observer.h"
@@ -72,13 +71,6 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityExploitBrowserTest,
// create a "blob:chrome-extension://" resource.
IN_PROC_BROWSER_TEST_F(ChromeSecurityExploitBrowserTest,
CreateBlobInExtensionOrigin) {
- // This test relies on extensions documents running in extension processes,
- // which is guaranteed with --isolate-extensions. Without it, the checks are
- // not enforced and this test will time out waiting for the process to be
- // killed.
- if (!extensions::IsIsolateExtensionsEnabled())
- return;
-
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL("a.root-servers.net", "/title1.html"));
@@ -184,15 +176,9 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityExploitBrowserTest,
)";
EXPECT_TRUE(content::ExecuteScriptAndExtractString(rfh, script, &body));
- if (extensions::IsIsolateExtensionsEnabled()) {
- EXPECT_EQ(
- "\nYour file was not found\n"
- "It may have been moved or deleted.\n"
- "ERR_FILE_NOT_FOUND\n",
- body);
- } else {
- // Without --isolate-extensions, the above steps must succeed, since
- // unblessed extension frames are allowed in ordinary renderer processes.
- EXPECT_EQ("pwned.", body);
- }
+ EXPECT_EQ(
+ "\nYour file was not found\n"
+ "It may have been moved or deleted.\n"
+ "ERR_FILE_NOT_FOUND\n",
+ body);
}

Powered by Google App Engine
This is Rietveld 408576698