Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: chrome/browser/extensions/process_management_browsertest.cc

Issue 2850793005: Remove command line/field trial support and configs for Isolate Extensions. (Closed)
Patch Set: Remove unused headers from extension_process_policy.h Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/process_management_browsertest.cc
diff --git a/chrome/browser/extensions/process_management_browsertest.cc b/chrome/browser/extensions/process_management_browsertest.cc
index 42892e4633a449de293fbf6c1d7335fa024a09d3..f0702c845664ff03110221a60a1beca0668908ee 100644
--- a/chrome/browser/extensions/process_management_browsertest.cc
+++ b/chrome/browser/extensions/process_management_browsertest.cc
@@ -326,11 +326,9 @@ IN_PROC_BROWSER_TEST_F(ProcessManagementTest,
// Verify that the navigation transferred the contents to another renderer
// process.
- if (extensions::IsIsolateExtensionsEnabled()) {
- content::RenderProcessHost* new_process_host =
- web_contents->GetMainFrame()->GetProcess();
- EXPECT_NE(old_process_host, new_process_host);
- }
+ content::RenderProcessHost* new_process_host =
+ web_contents->GetMainFrame()->GetProcess();
+ EXPECT_NE(old_process_host, new_process_host);
}
IN_PROC_BROWSER_TEST_F(ChromeWebStoreProcessTest,
@@ -366,21 +364,12 @@ IN_PROC_BROWSER_TEST_F(ChromeWebStoreProcessTest,
// Store gallery URL (which will commit into a chrome-extension://cws-app-id).
bool ignored_script_result = false;
content::TestNavigationObserver nav_observer(web_contents, 1);
- content::RenderProcessHostWatcher crash_observer(
- web_contents->GetMainFrame()->GetProcess(),
- content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
web_contents, navigation_starting_script, &ignored_script_result));
- // When --isolate-extensions is enabled, the expectation is that the store
- // will be properly put in its own process, otherwise the renderer process
- // is going to be terminated.
- if (!extensions::IsIsolateExtensionsEnabled()) {
- crash_observer.Wait();
- return;
- }
-
+ // The expectation is that the store will be properly put in its own process,
+ // otherwise the renderer process is going to be terminated.
// Verify that the navigation succeeded.
nav_observer.Wait();
EXPECT_EQ(cws_web_url, web_contents->GetLastCommittedURL());

Powered by Google App Engine
This is Rietveld 408576698