Remove command line/field trial support and configs for Isolate Extensions.

chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 713 matching lines @@
   // Verify that the browser action turned the background color red.
   const std::string script =
       "window.domAutomationController.send(document.body.style."
       "backgroundColor);";
   std::string result;
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(tab, script, &result));
   EXPECT_EQ(result, "red");
 }
 
 // Test that a browser action popup with a web iframe works correctly. This
-// primarily targets --isolate-extensions and --site-per-process modes, where
+// primarily targets site isolation modes, such as --site-per-process, where
 // the iframe runs in a separate process.  See https://crbug.com/546267.

[ncarter (slow), 2017/05/01 20:15:19]

"This primarily targets ..." -> "The iframe is expected to run in a separate
process."

[nasko, 2017/05/01 21:25:37]

Done.

 IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionPopupWithIframe) {
   host_resolver()->AddRule("*", "127.0.0.1");
   ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("browser_action/popup_with_iframe")));
   BrowserActionTestUtil* actions_bar = GetBrowserActionsBar();
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
@@ skipping 197 matching lines @@
   }
 
   const Extension* popup_extension_;
   const Extension* other_extension_;
 };
 
 // Tests that an extension pop-up cannot be navigated to a web page.
 IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, Webpage) {
   GURL web_url(embedded_test_server()->GetURL("foo.com", "/title1.html"));
 
-  // With and without --isolate-extension the GET request will be blocked in
-  // ExtensionViewHost::OpenURLFromTab (which silently drops navigations with
-  // CURRENT_TAB disposition).
+  // The GET request will be blocked in ExtensionViewHost::OpenURLFromTab
+  // (which silently drops navigations with CURRENT_TAB disposition).
   TestPopupNavigationViaGet(web_url, EXPECTING_NAVIGATION_FAILURE);
 
   // POST requests don't go through ExtensionViewHost::OpenURLFromTab.
-  //
-  // Without --isolate-extensions, there is no process transfer to isolate
-  // extensions into separate processes and therefore
-  // 1) navigating a popup extension to a webpage will succeed (because
-  //    ExtensionViewHost::ShouldTransferNavigation won't get called when there
-  //    is no transfer),
-  // 2) the webpage will stay in the same renderer process.
-  // This behavior is okay without --isolate-extensions (where webpages and
-  // extensions can coexist in the same process in other scenarios) - therefore
-  // no test verification is needed in this case.
-  //
-  // With --isolate-extensions the navigation should be blocked by
-  // ExtensionViewHost::ShouldTransferNavigation.  Test verification is
-  // important in --isolate-extensions mode, because this mode is all about
-  // isolating extensions and webpages into separate processes and therefore we
-  // need to ensure the behavior described above doesn't occur (i.e. that
-  // instead the webpage navigation in an extension popup fails).
-  if (extensions::IsIsolateExtensionsEnabled())
-    TestPopupNavigationViaPost(web_url, EXPECTING_NAVIGATION_FAILURE);
+  TestPopupNavigationViaPost(web_url, EXPECTING_NAVIGATION_FAILURE);
 }
 
 // Tests that an extension pop-up can be navigated to another page
 // in the same extension.
 IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest,
                        PageInSameExtension) {
   GURL other_page_in_same_extension =
       popup_extension().GetResourceURL("other_page.html");
   TestPopupNavigationViaGet(other_page_in_same_extension,
                             EXPECTING_NAVIGATION_SUCCESS);
@@ skipping 55 matching lines @@
   // The test verification below is applicable only to scenarios where the
   // download shelf is supported - on ChromeOS, instead of the download shelf,
   // there is a download notification in the right-bottom corner of the screen.
 #if !defined(OS_CHROMEOS)
   EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
 #endif
 }
 
 }  // namespace
 }  // namespace extensions