Remove command line/field trial support and configs for Isolate Extensions.

chrome/browser/chrome_security_exploit_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/extensions/extension_process_policy.h"

[Lei Zhang, 2017/05/02 21:32:01]

No longer used.

[nasko, 2017/05/03 04:04:19]

Done.

 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_request_details.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/content_switches.h"
@@ skipping 41 matching lines @@
   std::string status;
   std::string expected_status("0");
   EXPECT_TRUE(msg_queue.WaitForMessage(&status));
   EXPECT_STREQ(status.c_str(), expected_status.c_str());
 }
 
 // Extension isolation prevents a normal renderer process from being able to
 // create a "blob:chrome-extension://" resource.
 IN_PROC_BROWSER_TEST_F(ChromeSecurityExploitBrowserTest,
                        CreateBlobInExtensionOrigin) {
-  // This test relies on extensions documents running in extension processes,
-  // which is guaranteed with --isolate-extensions. Without it, the checks are
-  // not enforced and this test will time out waiting for the process to be
-  // killed.
-  if (!extensions::IsIsolateExtensionsEnabled())
-    return;
-
   ui_test_utils::NavigateToURL(
       browser(),
       embedded_test_server()->GetURL("a.root-servers.net", "/title1.html"));
 
   content::RenderFrameHost* rfh =
       browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame();
 
   // All these are attacker controlled values. The UUID is arbitrary.
   std::string blob_id = "2ce53a26-0409-45a3-86e5-f8fb9f5566d8";
   std::string blob_type = "text/html";
@@ skipping 82 matching lines @@
 
   // Now navigate to |target_url| in a new tab. It should not contain |payload|.
   AddTabAtIndex(0, target_url, ui::PAGE_TRANSITION_TYPED);
   content::WaitForLoadStop(browser()->tab_strip_model()->GetWebContentsAt(0));
   rfh = browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame();
   EXPECT_EQ(GURL(target_origin), rfh->GetSiteInstance()->GetSiteURL());
   std::string body;
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       rfh, "window.domAutomationController.send(document.body.innerText);",
       &body));
-  if (extensions::IsIsolateExtensionsEnabled()) {
-    EXPECT_EQ(
-        "\nYour file was not found\n\n"
-        "It may have been moved or deleted.\n"
-        "ERR_FILE_NOT_FOUND\n",
-        body);
-  } else {
-    // Without --isolate-extensions, the above steps must succeed, since
-    // unblessed extension frames are allowed in ordinary renderer processes.
-    EXPECT_EQ("pwned.", body);
-  }
+  EXPECT_EQ(
+      "\nYour file was not found\n\n"
+      "It may have been moved or deleted.\n"
+      "ERR_FILE_NOT_FOUND\n",
+      body);
 }