Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2850693002: Trailing commas for named args in Flutter cons invocations (flutter-intellij#551). (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Trailing commas for named args in Flutter cons invocations (flutter-intellij#551). * adds trailing commas to named params in Flutter instance creations * adds trailing commas to default value boilerplate See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :) R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/efb5c5ddc5f3b17e706a69da80964ce7a0eb73df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 3 chunks +22 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 4 chunks +80 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/correction/flutter_util.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pquitslund
3 years, 7 months ago (2017-04-27 21:51:16 UTC) #3
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-27 21:55:50 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as efb5c5ddc5f3b17e706a69da80964ce7a0eb73df (presubmit successful).
3 years, 7 months ago (2017-04-27 21:58:09 UTC) #6
danrubel
3 years, 7 months ago (2017-04-27 22:01:29 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698