Get astBuilder and typeInferenceEngine from SourceLoader.

Get astBuilder and typeInferenceEngine from SourceLoader.

This avoids some unnecessary plumbing.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/3c04fa0007531373b1d68cac0b2a06426d8cc559

[Paul Berry, 2017-04-28 22:12:21]

paulberry@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-05-04 17:35:22]

lgtm

https://codereview.chromium.org/2850683004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/builder.dart (right):

https://codereview.chromium.org/2850683004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/builder.dart:65: show SourceLibraryBuilder;
Could we add a loader property to LibraryBuilder to avoid this import?

[Paul Berry, 2017-05-04 20:09:26]

https://codereview.chromium.org/2850683004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/builder.dart (right):

https://codereview.chromium.org/2850683004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/builder.dart:65: show SourceLibraryBuilder;
On 2017/05/04 17:35:22, ahe wrote:
> Could we add a loader property to LibraryBuilder to avoid this import?

LibraryBuilder already has a loader property but it returns Loader.  By using
SourceLibraryBuilder instead we take advantage of the fact that
SourceLibraryBuilder.library returns SourceLoader.  That's needed in
kernel_field_builder.dart so that we can do `library.loader.typeInferenceEngine`
and `library.loader.astFactory` without having to do a cast.

Leaving as is for now.  If you feel strongly about this we can always do a
follow up CL.

[Paul Berry, 2017-05-04 20:46:15]

Description was changed from

==========
Get astBuilder and typeInferenceEngine from SourceLoader.

This avoids some unnecessary plumbing.
==========

to

==========
Get astBuilder and typeInferenceEngine from SourceLoader.

This avoids some unnecessary plumbing.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3c04fa0007531373b1d68cac0b2a06426d8cc559
==========

[Paul Berry, 2017-05-04 20:46:17]

Committed patchset #1 (id:1) manually as
3c04fa0007531373b1d68cac0b2a06426d8cc559 (presubmit successful).