Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleMap.cpp

Issue 2850673002: Move a RegisterModuleScript() call to ModuleScript::Create() (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ModuleScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ModuleMap.cpp
diff --git a/third_party/WebKit/Source/core/dom/ModuleMap.cpp b/third_party/WebKit/Source/core/dom/ModuleMap.cpp
index ddab410e6adee56c3ea7710b521d865f77a807ab..ea685c364e41b72adcecbe5c4afa28caeeee8a35 100644
--- a/third_party/WebKit/Source/core/dom/ModuleMap.cpp
+++ b/third_party/WebKit/Source/core/dom/ModuleMap.cpp
@@ -6,7 +6,6 @@
#include "core/dom/Modulator.h"
#include "core/dom/ModuleScript.h"
-#include "core/dom/ScriptModuleResolver.h"
#include "core/loader/modulescript/ModuleScriptFetchRequest.h"
#include "core/loader/modulescript/ModuleScriptLoaderClient.h"
#include "platform/WebTaskRunner.h"
@@ -90,11 +89,6 @@ void ModuleMap::Entry::NotifyNewSingleModuleFinished(
module_script_ = module_script;
is_fetching_ = false;
- if (module_script_) {
- map_->GetModulator()->GetScriptModuleResolver()->RegisterModuleScript(
- module_script_);
- }
-
for (const auto& client : clients_) {
DispatchFinishedNotificationAsync(client);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ModuleScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698