Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2850653002: Enable NetProxyPreconnects experiment by default (Closed)
Patch Set: xunjieli comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl.cc ('k') | net/spdy/chromium/spdy_test_util_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 9565d7f591aaa9acbbfc68d1e566dbc83e7d7c7a..dc37a7a922430b772ddfcfca0f8fbd87da2b877b 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -1187,13 +1187,11 @@ TEST_F(HttpStreamFactoryTest, OnlyOnePreconnectToProxyServer) {
}
SpdySessionDependencies session_deps;
- session_deps.restrict_to_one_preconnect_for_proxies = true;
HttpNetworkSession::Params params =
SpdySessionDependencies::CreateSessionParams(&session_deps);
params.enable_quic = true;
params.proxy_service = proxy_service.get();
params.http_server_properties = &http_server_properties;
- ASSERT_TRUE(params.restrict_to_one_preconnect_for_proxies);
std::unique_ptr<HttpNetworkSession> session(
new HttpNetworkSession(params));
@@ -1278,13 +1276,11 @@ TEST_F(HttpStreamFactoryTest, ProxyServerPreconnectDifferentPrivacyModes) {
http_server_properties.SetSupportsSpdy(spdy_server, true);
SpdySessionDependencies session_deps;
- session_deps.restrict_to_one_preconnect_for_proxies = true;
HttpNetworkSession::Params params =
SpdySessionDependencies::CreateSessionParams(&session_deps);
params.enable_quic = true;
params.proxy_service = proxy_service.get();
params.http_server_properties = &http_server_properties;
- ASSERT_TRUE(params.restrict_to_one_preconnect_for_proxies);
std::unique_ptr<HttpNetworkSession> session(new HttpNetworkSession(params));
@@ -1700,7 +1696,6 @@ TEST_F(HttpStreamFactoryTest, RequestHttpStreamOverProxy) {
TEST_F(HttpStreamFactoryTest, RequestHttpStreamOverProxyWithPreconnects) {
SpdySessionDependencies session_deps(
ProxyService::CreateFixed("https://myproxy.org:443"));
- session_deps.restrict_to_one_preconnect_for_proxies = true;
// Set up the proxy server as a server that supports request priorities.
std::unique_ptr<HttpServerPropertiesImpl> http_server_properties(
« no previous file with comments | « net/http/http_stream_factory_impl.cc ('k') | net/spdy/chromium/spdy_test_util_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698