build/android/pylib/gtest/test_package_apk.py - Issue 285063002: Removed unneccessary wait that caused 10s timeout per gtest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 285063002: Removed unneccessary wait that caused 10s timeout per gtest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index d2292b5960ac00097c59b542bb5d54230dbfb0f7..9d3dac541ea580c49c464cdfca19238abc94634b 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -74,7 +74,8 @@ class TestPackageApk(TestPackage):

device.old_interface.StartActivity(

self._package_info.package,

self._package_info.activity,

- wait_for_completion=True,

+ # No wait since the runner waits for FIFO creation anyway.

+ wait_for_completion=False,

action='android.intent.action.MAIN',

force_stop=True)

« no previous file with comments | « no previous file | no next file » | no next file with comments »