Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: content/renderer/renderer_blink_platform_impl.h

Issue 2850593002: Revert of [blink] Unique pointers in Platform.h (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_blink_platform_impl.h
diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h
index 282827fe37bd454f7efc5ac430adfb479c7db89a..ff5ee76fa0baa1301cfc0ae665aa23769b740f8a 100644
--- a/content/renderer/renderer_blink_platform_impl.h
+++ b/content/renderer/renderer_blink_platform_impl.h
@@ -81,7 +81,7 @@
blink::WebSandboxSupport* GetSandboxSupport() override;
blink::WebCookieJar* CookieJar() override;
blink::WebThemeEngine* ThemeEngine() override;
- std::unique_ptr<blink::WebSpeechSynthesizer> CreateSpeechSynthesizer(
+ blink::WebSpeechSynthesizer* CreateSpeechSynthesizer(
blink::WebSpeechSynthesizerClient* client) override;
virtual bool sandboxEnabled();
unsigned long long VisitedLinkHash(const char* canonicalURL,
@@ -104,8 +104,7 @@
const blink::WebString& cacheStorageCacheName) override;
blink::WebString DefaultLocale() override;
void SuddenTerminationChanged(bool enabled) override;
- std::unique_ptr<blink::WebStorageNamespace> CreateLocalStorageNamespace()
- override;
+ blink::WebStorageNamespace* CreateLocalStorageNamespace() override;
blink::Platform::FileHandle DatabaseOpenFile(
const blink::WebString& vfs_file_name,
int desired_flags) override;
@@ -128,7 +127,7 @@
blink::WebPublicSuffixList* PublicSuffixList() override;
blink::WebScrollbarBehavior* ScrollbarBehavior() override;
blink::WebIDBFactory* IdbFactory() override;
- std::unique_ptr<blink::WebServiceWorkerCacheStorage> CreateCacheStorage(
+ blink::WebServiceWorkerCacheStorage* CacheStorage(
const blink::WebSecurityOrigin& security_origin) override;
blink::WebFileSystem* FileSystem() override;
blink::WebString FileSystemCreateOriginIdentifier(
@@ -142,7 +141,7 @@
unsigned AudioHardwareOutputChannels() override;
blink::WebDatabaseObserver* DatabaseObserver() override;
- std::unique_ptr<blink::WebAudioDevice> CreateAudioDevice(
+ blink::WebAudioDevice* CreateAudioDevice(
unsigned input_channels,
unsigned channels,
const blink::WebAudioLatencyHint& latency_hint,
@@ -154,21 +153,18 @@
const char* audio_file_data,
size_t data_size) override;
- std::unique_ptr<blink::WebMIDIAccessor> CreateMIDIAccessor(
+ blink::WebMIDIAccessor* CreateMIDIAccessor(
blink::WebMIDIAccessorClient* client) override;
blink::WebBlobRegistry* GetBlobRegistry() override;
void SampleGamepads(device::Gamepads&) override;
- std::unique_ptr<blink::WebRTCPeerConnectionHandler>
- CreateRTCPeerConnectionHandler(
+ blink::WebRTCPeerConnectionHandler* CreateRTCPeerConnectionHandler(
blink::WebRTCPeerConnectionHandlerClient* client) override;
- std::unique_ptr<blink::WebRTCCertificateGenerator>
- CreateRTCCertificateGenerator() override;
- std::unique_ptr<blink::WebMediaRecorderHandler> CreateMediaRecorderHandler()
- override;
- std::unique_ptr<blink::WebMediaStreamCenter> CreateMediaStreamCenter(
+ blink::WebRTCCertificateGenerator* CreateRTCCertificateGenerator() override;
+ blink::WebMediaRecorderHandler* CreateMediaRecorderHandler() override;
+ blink::WebMediaStreamCenter* CreateMediaStreamCenter(
blink::WebMediaStreamCenterClient* client) override;
- std::unique_ptr<blink::WebCanvasCaptureHandler> CreateCanvasCaptureHandler(
+ blink::WebCanvasCaptureHandler* CreateCanvasCaptureHandler(
const blink::WebSize& size,
double frame_rate,
blink::WebMediaStreamTrack* track) override;
@@ -178,15 +174,13 @@
void CreateHTMLAudioElementCapturer(
blink::WebMediaStream* web_media_stream,
blink::WebMediaPlayer* web_media_player) override;
- std::unique_ptr<blink::WebImageCaptureFrameGrabber>
- CreateImageCaptureFrameGrabber() override;
- std::unique_ptr<blink::WebGraphicsContext3DProvider>
- CreateOffscreenGraphicsContext3DProvider(
+ blink::WebImageCaptureFrameGrabber* CreateImageCaptureFrameGrabber() override;
+ blink::WebGraphicsContext3DProvider* CreateOffscreenGraphicsContext3DProvider(
const blink::Platform::ContextAttributes& attributes,
const blink::WebURL& top_document_web_url,
blink::WebGraphicsContext3DProvider* share_provider,
blink::Platform::GraphicsInfo* gl_info) override;
- std::unique_ptr<blink::WebGraphicsContext3DProvider>
+ blink::WebGraphicsContext3DProvider*
CreateSharedOffscreenGraphicsContext3DProvider() override;
gpu::GpuMemoryBufferManager* GetGpuMemoryBufferManager() override;
std::unique_ptr<cc::SharedBitmap> AllocateSharedBitmap(
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698