third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp - Issue 2850593002: Revert of [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

Issue 2850593002: Revert of [blink] Unique pointers in Platform.h (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp ('k') | third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

diff --git a/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp b/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

index 0ba9da021e13ee62e5ab337c839716887102aa77..a338af74f49c37716ccde2631ec1d372ea93f5cc 100644

--- a/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

+++ b/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

@@ -55,13 +55,12 @@

WebMediaStreamTrack track;

const WebSize size(element.width(), element.height());

std::unique_ptr<WebCanvasCaptureHandler> handler;

- if (given_frame_rate) {

- handler = Platform::Current()->CreateCanvasCaptureHandler(size, frame_rate,

- &track);

- } else {

- handler = Platform::Current()->CreateCanvasCaptureHandler(

- size, kDefaultFrameRate, &track);

- }

+ if (given_frame_rate)

+ handler = WTF::WrapUnique(Platform::Current()->CreateCanvasCaptureHandler(

+ size, frame_rate, &track));

+ else

+ handler = WTF::WrapUnique(Platform::Current()->CreateCanvasCaptureHandler(

+ size, kDefaultFrameRate, &track));

if (!handler) {

exception_state.ThrowDOMException(