Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2850553002: Autoplay: use an autoplay policy setting in Blink. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/media/resources/autoplay-crossorigin-iframe.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 80eba094cebbfc955babe931fb9559c6f4c41477..0bc2afa62c5c66751717dbe44c640eb97e0d42e3 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1050,19 +1050,18 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,
prefs.do_not_update_selection_on_mutating_selection_range);
#endif // defined(OS_ANDROID)
- // TODO(mlamouri): use an AutoplayPolicy in WebSettings.
switch (prefs.autoplay_policy) {
case AutoplayPolicy::kNoUserGestureRequired:
- settings->SetMediaPlaybackRequiresUserGesture(false);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(false);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kNoUserGestureRequired);
break;
case AutoplayPolicy::kUserGestureRequired:
- settings->SetMediaPlaybackRequiresUserGesture(true);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(false);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kUserGestureRequired);
break;
case AutoplayPolicy::kUserGestureRequiredForCrossOrigin:
- settings->SetMediaPlaybackRequiresUserGesture(false);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(true);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kUserGestureRequiredForCrossOrigin);
break;
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/media/resources/autoplay-crossorigin-iframe.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698