Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2850553002: Autoplay: use an autoplay policy setting in Blink. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index f384b63ffbd426ae35ed426c39744628c4271786..240d565bb6d0edde506cfe5b48f063b5b6676e1c 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1056,19 +1056,18 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,
prefs.do_not_update_selection_on_mutating_selection_range);
#endif // defined(OS_ANDROID)
- // TODO(mlamouri): use an AutoplayPolicy in WebSettings.
switch (prefs.autoplay_policy) {
case AutoplayPolicy::kNoUserGestureRequired:
- settings->SetMediaPlaybackRequiresUserGesture(false);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(false);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kNoUserGestureRequired);
break;
case AutoplayPolicy::kCrossOriginUserGestureRequired:
- settings->SetMediaPlaybackRequiresUserGesture(false);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(true);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kCrossOriginUserGestureRequired);
break;
case AutoplayPolicy::kUserGestureRequired:
- settings->SetMediaPlaybackRequiresUserGesture(true);
- settings->SetCrossOriginMediaPlaybackRequiresUserGesture(false);
+ settings->SetAutoplayPolicy(
+ WebSettings::AutoplayPolicy::kUserGestureRequired);
break;
}

Powered by Google App Engine
This is Rietveld 408576698