Revert "Extend file-system abstraction with a couple methods, remove context."

Revert "Extend file-system abstraction with a couple methods, remove context."

This reverts commit 102de9e476bcd2b17f35604a7a3e442b28e14194.

TBR=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/95f15308c8eaf867398e2f780e955e33a860dcbf

[Dmitry Stefantsov, 2017-04-28 10:49:52]

There were errors on different bots in the tests added by this commit.

The main source of issues is the file
pkg/front_end/test/physical_file_system_test.dart, class DirectoryTest. The bots
complained about the method test_readAsBytes.

Locally I was able to reproduce a similar error. I ran a hundred of instances of
the test (like this: for i in {1..100}; do python tools/test.py -mrelease
--checked -t60 pkg/front_end/test/physical_file_system_test & done), and it was
complaining about the method test_exists_directoryExists.

Both test_readAsBytes and test_exists_directoryExists are marked as async.
Maybe, that's the source of the issues.

[Dmitry Stefantsov, 2017-04-28 10:50:49]

Description was changed from

==========
Revert "Extend file-system abstraction with a couple methods, remove context."

This reverts commit 102de9e476bcd2b17f35604a7a3e442b28e14194.

TBR=sigmund@google.com
==========

to

==========
Revert "Extend file-system abstraction with a couple methods, remove context."

This reverts commit 102de9e476bcd2b17f35604a7a3e442b28e14194.

TBR=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95f15308c8eaf867398e2f780e955e33a860dcbf
==========

[Dmitry Stefantsov, 2017-04-28 10:50:50]

Committed patchset #1 (id:1) manually as
95f15308c8eaf867398e2f780e955e33a860dcbf (presubmit successful).

[Siggi Cherem (dart-lang), 2017-04-28 22:58:20]

Thanks for looking into it and reverting!

I noticed a missing await in the test, so you might be right about the cause.
Weird that the failure only occurs in the windows bots, though.