Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 2850533003: Log the creation of a dialog boxes using DialogDelegate. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index fd977cd937c355b53f9d48df75f27412effaa718..6af25ee59accfbcb26ef5379fe67751d4fff6cef 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "build/build_config.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/base/l10n/l10n_util.h"
@@ -31,7 +32,9 @@ namespace views {
////////////////////////////////////////////////////////////////////////////////
// DialogDelegate:
-DialogDelegate::DialogDelegate() : supports_custom_frame_(true) {}
+DialogDelegate::DialogDelegate() : supports_custom_frame_(true) {
+ UMA_HISTOGRAM_BOOLEAN("Dialog.Delegate.Creation", true);
msw 2017/05/01 21:51:30 Why BOOLEAN? Shouldn't this be UMA_HISTOGRAM_COUNT
jwd 2017/05/03 20:14:40 No, it's confusing naming. UMA_HISTOGRAM_COUNTS_*
msw 2017/05/03 22:53:22 Acknowledged.
+}
DialogDelegate::~DialogDelegate() {}
« tools/metrics/histograms/histograms.xml ('K') | « tools/metrics/histograms/histograms.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698