Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: net/quic/core/quic_session.cc

Issue 2850523002: QUIC: correctly update local stream state on receipt of trailers after sending RST. Protected by FL… (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_session.h ('k') | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session.cc
diff --git a/net/quic/core/quic_session.cc b/net/quic/core/quic_session.cc
index 9508fe39524d94d1f6603cf49a52a2503eccc917..241f29290e11be3ef6a9a2e37cff2869bb2aa1dc 100644
--- a/net/quic/core/quic_session.cc
+++ b/net/quic/core/quic_session.cc
@@ -77,7 +77,7 @@ void QuicSession::OnStreamFrame(const QuicStreamFrame& frame) {
// us this offset.
if (frame.fin) {
QuicStreamOffset final_byte_offset = frame.offset + frame.data_length;
- UpdateFlowControlOnFinalReceivedByteOffset(stream_id, final_byte_offset);
+ OnFinalByteOffsetReceived(stream_id, final_byte_offset);
}
return;
}
@@ -394,7 +394,7 @@ void QuicSession::CloseStreamInner(QuicStreamId stream_id, bool locally_reset) {
connection_->SetNumOpenStreams(dynamic_stream_map_.size());
}
-void QuicSession::UpdateFlowControlOnFinalReceivedByteOffset(
+void QuicSession::OnFinalByteOffsetReceived(
QuicStreamId stream_id,
QuicStreamOffset final_byte_offset) {
std::map<QuicStreamId, QuicStreamOffset>::iterator it =
@@ -533,8 +533,7 @@ void QuicSession::HandleRstOnValidNonexistentStream(
if (IsClosedStream(frame.stream_id)) {
// The RST frame contains the final byte offset for the stream: we can now
// update the connection level flow controller if needed.
- UpdateFlowControlOnFinalReceivedByteOffset(frame.stream_id,
- frame.byte_offset);
+ OnFinalByteOffsetReceived(frame.stream_id, frame.byte_offset);
}
}
« no previous file with comments | « net/quic/core/quic_session.h ('k') | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698