Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: net/quic/core/spdy_utils.h

Issue 2850513002: Delete QUIC/SPDY utility methods for parsing headers/trailers. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/spdy_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/spdy_utils.h
diff --git a/net/quic/core/spdy_utils.h b/net/quic/core/spdy_utils.h
index 4f3f62ba38be16859187b805af88318b552f54f5..724136af20e8216c40eebc1cf8644165c3d8e13f 100644
--- a/net/quic/core/spdy_utils.h
+++ b/net/quic/core/spdy_utils.h
@@ -22,40 +22,18 @@ class QUIC_EXPORT_PRIVATE SpdyUtils {
static std::string SerializeUncompressedHeaders(
const SpdyHeaderBlock& headers);
- // Parses |data| as a string containing serialized HTTP/2 HEADERS frame,
- // populating |headers| with the key->value pairs found.
- // |content_length| will be populated with the value of the content-length
- // header if one or more are present.
- // Returns true on success, false if parsing fails, or invalid keys are found.
- static bool ParseHeaders(const char* data,
- uint32_t data_len,
- int64_t* content_length,
- SpdyHeaderBlock* headers);
-
// Populate |content length| with the value of the content-length header.
// Returns true on success, false if parsing fails or content-length header is
// missing.
static bool ExtractContentLengthFromHeaders(int64_t* content_length,
SpdyHeaderBlock* headers);
- // Parses |data| as a string containing serialized HTTP/2 HEADERS frame,
- // populating |trailers| with the key->value pairs found.
- // The final offset header will be excluded from |trailers|, and instead the
- // value will be copied to |final_byte_offset|.
- // Returns true on success, false if parsing fails, or invalid keys are found.
- static bool ParseTrailers(const char* data,
- uint32_t data_len,
- size_t* final_byte_offset,
- SpdyHeaderBlock* trailers);
-
- // Copies a list of headers to a SpdyHeaderBlock. Performs similar validation
- // to SpdyFramer::ParseHeaderBlockInBuffer and ParseHeaders, above.
+ // Copies a list of headers to a SpdyHeaderBlock.
static bool CopyAndValidateHeaders(const QuicHeaderList& header_list,
int64_t* content_length,
SpdyHeaderBlock* headers);
- // Copies a list of headers to a SpdyHeaderBlock. Performs similar validation
- // to SpdyFramer::ParseHeaderBlockInBuffer and ParseTrailers, above.
+ // Copies a list of headers to a SpdyHeaderBlock.
static bool CopyAndValidateTrailers(const QuicHeaderList& header_list,
size_t* final_byte_offset,
SpdyHeaderBlock* trailers);
« no previous file with comments | « no previous file | net/quic/core/spdy_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698