Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/ui/views/exclusive_access_bubble_views.h

Issue 2850403002: Fix crash under ExclusiveAccessBubbleViews::AnimationProgressed(). (Closed)
Patch Set: Fix lifetime, clang Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/exclusive_access_bubble_views.h
diff --git a/chrome/browser/ui/views/exclusive_access_bubble_views.h b/chrome/browser/ui/views/exclusive_access_bubble_views.h
index 46d06a732e3189b37655020d2993aeeb539ad6df..fb93a95e3881bc9678bff54842448f147ff08e49 100644
--- a/chrome/browser/ui/views/exclusive_access_bubble_views.h
+++ b/chrome/browser/ui/views/exclusive_access_bubble_views.h
@@ -61,7 +61,7 @@ class ExclusiveAccessBubbleViews : public ExclusiveAccessBubble,
// Returns the root view containing |browser_view_|.
views::View* GetBrowserRootView() const;
- // ExclusiveAccessBubble overrides:
+ // ExclusiveAccessBubble:
void AnimationProgressed(const gfx::Animation* animation) override;
void AnimationEnded(const gfx::Animation* animation) override;
gfx::Rect GetPopupRect(bool ignore_animation_state) const override;
@@ -73,12 +73,13 @@ class ExclusiveAccessBubbleViews : public ExclusiveAccessBubble,
bool IsAnimating() override;
bool CanMouseTriggerSlideIn() const override;
- // content::NotificationObserver override:
+ // content::NotificationObserver:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
- // views::WidgetObserver override:
+ // views::WidgetObserver:
+ void OnWidgetDestroyed(views::Widget* widget) override;
void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override;
// views::LinkListener override:

Powered by Google App Engine
This is Rietveld 408576698