chrome/browser/ui/views/exclusive_access_bubble_views_context.h - Issue 2850403002: Fix crash under ExclusiveAccessBubbleViews::AnimationProgressed().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/exclusive_access_bubble_views_context.h

Issue 2850403002: Fix crash under ExclusiveAccessBubbleViews::AnimationProgressed(). (Closed)

Patch Set: Fix lifetime, clang Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/exclusive_access_bubble_views.cc ('K') | « chrome/browser/ui/views/exclusive_access_bubble_views.cc ('k') | chrome/browser/ui/views/exclusive_access_bubble_views_interactive_uitest.cc » ('j') | chrome/browser/ui/views/exclusive_access_bubble_views_interactive_uitest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 #ifndef CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_	4 #ifndef CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_

5 #define CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_	5 #define CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_

6	6

7 #include "ui/gfx/geometry/rect.h"	7 #include "ui/gfx/geometry/rect.h"

8 #include "ui/gfx/native_widget_types.h"	8 #include "ui/gfx/native_widget_types.h"

9	9

10 class ExclusiveAccessManager;	10 class ExclusiveAccessManager;

(...skipping 29 matching lines...) Expand all Loading...
40 virtual gfx::Point GetCursorPointInParent() const = 0;	40 virtual gfx::Point GetCursorPointInParent() const = 0;

41	41

42 // Return the current bounds (not restored bounds) of the parent window.	42 // Return the current bounds (not restored bounds) of the parent window.

43 virtual gfx::Rect GetClientAreaBoundsInScreen() const = 0;	43 virtual gfx::Rect GetClientAreaBoundsInScreen() const = 0;

44	44

45 // Returns true if immersive mode is enabled.	45 // Returns true if immersive mode is enabled.

46 virtual bool IsImmersiveModeEnabled() = 0;	46 virtual bool IsImmersiveModeEnabled() = 0;

47	47

48 // Returns the bounds of the top level View in screen coordinate system.	48 // Returns the bounds of the top level View in screen coordinate system.

49 virtual gfx::Rect GetTopContainerBoundsInScreen() = 0;	49 virtual gfx::Rect GetTopContainerBoundsInScreen() = 0;

	50

	51 // Destroy any exclusive active bubble.
	msw 2017/05/03 18:48:33 nit: "access", maybe describe why this is needed a nit: "access", maybe describe why this is needed akin to your comment in exclusive_access_bubble_views.cc? tapted 2017/05/04 06:42:07 Done. Show quoted text On 2017/05/03 18:48:33, msw wrote: > nit: "access", maybe describe why this is needed akin to your comment in > exclusive_access_bubble_views.cc? Done.
	52 virtual void DestroyAnyExclusiveAccessBubble() = 0;

50 };	53 };

51	54

52 #endif // CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_	55 #endif // CHROME_BROWSER_UI_VIEWS_EXCLUSIVE_ACCESS_BUBBLE_VIEWS_CONTEXT_H_

OLD	NEW