Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

Issue 2850373002: Make ChromeSubresourceFilterClient a WebContentsUserData (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
diff --git a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
index 3479cee5c95e8e55be56e03388fc59b8d5513b37..aff00a849c7179ab787e37b7557295236e43e132 100644
--- a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
+++ b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
@@ -114,10 +114,10 @@ class SubresourceFilterSafeBrowsingActivationThrottleTest
base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
kActivationScopeActivationList, kActivationListSubresourceFilter));
// Note: Using NiceMock to allow uninteresting calls and suppress warnings.
- auto client =
+ client_ =
base::MakeUnique<::testing::NiceMock<MockSubresourceFilterClient>>();
ContentSubresourceFilterDriverFactory::CreateForWebContents(
- RenderViewHostTestHarness::web_contents(), std::move(client));
+ RenderViewHostTestHarness::web_contents(), client_.get());
fake_safe_browsing_database_ = new FakeSafeBrowsingDatabaseManager();
NavigateAndCommit(GURL("https://test.com"));
Observe(RenderViewHostTestHarness::web_contents());
@@ -178,6 +178,7 @@ class SubresourceFilterSafeBrowsingActivationThrottleTest
std::unique_ptr<testing::ScopedSubresourceFilterFeatureToggle>
scoped_feature_toggle_;
std::unique_ptr<content::NavigationSimulator> navigation_simulator_;
+ std::unique_ptr<SubresourceFilterClient> client_;
scoped_refptr<FakeSafeBrowsingDatabaseManager> fake_safe_browsing_database_;
base::HistogramTester tester_;
content::NavigationHandle* navigation_handle_;

Powered by Google App Engine
This is Rietveld 408576698