Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2850373002: Make ChromeSubresourceFilterClient a WebContentsUserData (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
index 90c0cb1883d1e5745533ad1ee9340bd526de8d57..d7007459677dd492855776ac2f38b7fb7259882b 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
@@ -56,12 +56,12 @@ bool ShouldMeasurePerformanceForPageLoad(double performance_measurement_rate) {
// static
void ContentSubresourceFilterDriverFactory::CreateForWebContents(
content::WebContents* web_contents,
- std::unique_ptr<SubresourceFilterClient> client) {
+ SubresourceFilterClient* client) {
if (FromWebContents(web_contents))
return;
- web_contents->SetUserData(kWebContentsUserDataKey,
- new ContentSubresourceFilterDriverFactory(
- web_contents, std::move(client)));
+ web_contents->SetUserData(
+ kWebContentsUserDataKey,
+ new ContentSubresourceFilterDriverFactory(web_contents, client));
}
// static
@@ -84,9 +84,9 @@ bool ContentSubresourceFilterDriverFactory::NavigationIsPageReload(
ContentSubresourceFilterDriverFactory::ContentSubresourceFilterDriverFactory(
content::WebContents* web_contents,
- std::unique_ptr<SubresourceFilterClient> client)
+ SubresourceFilterClient* client)
: content::WebContentsObserver(web_contents),
- client_(std::move(client)),
+ client_(client),
throttle_manager_(
base::MakeUnique<ContentSubresourceFilterThrottleManager>(
this,

Powered by Google App Engine
This is Rietveld 408576698