Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2850343002: [Extensions Bindings] Add errors to API invocations (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add errors to API invocations Surface errors from argument and signature matching to the script that caused them. Add the ability to generate an expected script signature to include in the error. Add tests for signature generation and invocation error generation. BUG=653596 Review-Url: https://codereview.chromium.org/2850343002 Cr-Commit-Position: refs/heads/master@{#469779} Committed: https://chromium.googlesource.com/chromium/src/+/ea259a34782be0b2cc32d3ced99c845d53d838e2

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : . #

Total comments: 12

Patch Set 4 : lazyboy's, jbroman's #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -60 lines) Patch
M extensions/renderer/api_binding.cc View 1 2 3 4 4 chunks +6 lines, -2 lines 0 comments Download
M extensions/renderer/api_binding_hooks.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/renderer/api_binding_hooks.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M extensions/renderer/api_binding_unittest.cc View 1 2 3 4 9 chunks +56 lines, -17 lines 0 comments Download
M extensions/renderer/api_bindings_system_unittest.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M extensions/renderer/api_invocation_errors.h View 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/renderer/api_invocation_errors.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M extensions/renderer/api_invocation_errors_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/renderer/api_signature.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M extensions/renderer/api_signature.cc View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download
M extensions/renderer/api_signature_unittest.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M extensions/renderer/argument_spec.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/renderer/argument_spec.cc View 1 2 3 4 3 chunks +53 lines, -36 lines 0 comments Download
M extensions/renderer/argument_spec_unittest.cc View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 45 (38 generated)
Devlin
Heya folks, mind taking a look? (This one finally surfaces the error to the calling ...
3 years, 7 months ago (2017-05-02 15:07:22 UTC) #10
lazyboy
https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_binding_hooks.cc File extensions/renderer/api_binding_hooks.cc (right): https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_binding_hooks.cc#newcode275 extensions/renderer/api_binding_hooks.cc:275: RequestResult result(RequestResult::INVALID_INVOCATION); Overloading RequestResult constructor is a cleaner choice ...
3 years, 7 months ago (2017-05-02 16:09:47 UTC) #11
jbroman
lgtm once lazyboy is happy https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_signature.cc File extensions/renderer/api_signature.cc (right): https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_signature.cc#newcode348 extensions/renderer/api_signature.cc:348: static const char kOptionalPrefix[] ...
3 years, 7 months ago (2017-05-02 21:41:01 UTC) #12
Devlin
https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_binding_hooks.cc File extensions/renderer/api_binding_hooks.cc (right): https://codereview.chromium.org/2850343002/diff/40001/extensions/renderer/api_binding_hooks.cc#newcode275 extensions/renderer/api_binding_hooks.cc:275: RequestResult result(RequestResult::INVALID_INVOCATION); On 2017/05/02 16:09:47, lazyboy wrote: > Overloading ...
3 years, 7 months ago (2017-05-02 22:26:47 UTC) #14
lazyboy
lgtm
3 years, 7 months ago (2017-05-02 23:41:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850343002/140001
3 years, 7 months ago (2017-05-05 22:10:41 UTC) #41
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 22:20:46 UTC) #45
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/ea259a34782be0b2cc32d3ced99c...

Powered by Google App Engine
This is Rietveld 408576698